Skip to content

Address json store - #1100

Merged
ashchan merged 12 commits into
developfrom
address-json-store
Nov 14, 2019
Merged

Address json store#1100
ashchan merged 12 commits into
developfrom
address-json-store

Conversation

@ashchan

@ashchan ashchan commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Remove sqlite db for address, that we'd only have a single sqlite for cells
  • Use a simple JSON store to persist addresses data
  • The JSON store has sync interfaces - observe if this is fine
  • Leave space for future refactor/tweak around sync/cell db

@ashchan
ashchan merged commit 4de678c into develop Nov 14, 2019
@ashchan
ashchan deleted the address-json-store branch November 14, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Awaiting requested review from Keith-CY
1 more reviewer
@classicalliu classicalliu classicalliu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashchan @classicalliu